Messages in this thread | | | Date | Wed, 26 Oct 2016 14:02:06 +0200 | From | Cornelia Huck <> | Subject | Re: [PATCH] KVM: fix OOPS on flush_work |
| |
On Wed, 26 Oct 2016 13:44:50 +0200 Paolo Bonzini <pbonzini@redhat.com> wrote:
> The conversion done by commit 3706feacd007 ("KVM: Remove deprecated > create_singlethread_workqueue") is broken. It flushes a single work > item &irqfd->shutdown instead of all of them, and even worse if there > is no irqfd on the list then you get a NULL pointer dereference. > Revert the virt/kvm/eventfd.c part of that patch; to avoid the > deprecated function, just allocate our own workqueue---it does > not even have to be unbound---with alloc_workqueue. > > Fixes: 3706feacd007 > Cc: stable@vger.kernel.org > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > virt/kvm/eventfd.c | 22 +++++++++++++++++++--- > virt/kvm/kvm_main.c | 6 ++++++ > 2 files changed, 25 insertions(+), 3 deletions(-)
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
| |