Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH 1/2] kernel/smp: Make the SMP boot message common on all arches | Date | Wed, 26 Oct 2016 16:34:42 +1100 |
| |
Ingo Molnar <mingo@kernel.org> writes: > * Michael Ellerman <mpe@ellerman.id.au> wrote: >> @@ -564,8 +560,11 @@ void __init smp_init(void) >> cpu_up(cpu); >> } >> >> + num_nodes = num_online_nodes(); >> + pr_info("smp: Brought up %d node%s, %d CPUs\n", >> + num_nodes, (num_nodes > 1 ? "s" : ""), num_online_cpus()); > > No objections - but pedantry requires me to mention that while we are evolving > this code and changing the strings I think we should make the CPU announcement > CPU%s smart as well: an SMP kernel on a single CPU bootup will result in > num_online_cpus() == 1, right?
Yeah that makes sense. I don't often boot any single CPU systems, but I tested with maxcpus=1 and it does look nicer:
smp: Brought up 2 nodes, 1 CPU
Will send a v2.
cheers
| |