Messages in this thread | | | Subject | Re: [PATCH/RFT v2 07/17] ARM: davinci: da8xx: Enable the usb20 "per" clk on phy_clk_enable | From | David Lechner <> | Date | Tue, 25 Oct 2016 11:05:02 -0500 |
| |
On 10/25/2016 05:12 AM, Sekhar Nori wrote: > On Monday 24 October 2016 10:16 PM, ahaslam@baylibre.com wrote: >> diff --git a/arch/arm/mach-davinci/usb-da8xx.c b/arch/arm/mach-davinci/usb-da8xx.c >> index 9e41a7f..982e105 100644 >> --- a/arch/arm/mach-davinci/usb-da8xx.c >> +++ b/arch/arm/mach-davinci/usb-da8xx.c >> @@ -53,11 +53,19 @@ int __init da8xx_register_usb_refclkin(int rate) >> >> static void usb20_phy_clk_enable(struct clk *clk) >> { >> + struct clk *usb20_clk; >> u32 val; >> u32 timeout = 500000; /* 500 msec */ >> >> val = readl(DA8XX_SYSCFG0_VIRT(DA8XX_CFGCHIP2_REG)); >> >> + usb20_clk = clk_get(NULL, "usb20"); > > We should not be using a NULL device pointer here. Can you pass the musb > device pointer available in the same file? Also, da850_clks[] in da850.c > needs to be fixed to add the matching device name.
This clock can be used for usb 1.1 PHY even when musb is not being used, so I don't think we can depend on having a musb device here.
Also, in a previous review, it was decided that the usb clocks should *not* be added to da850_clks[] [1]. Instead, they are dynamically registered elsewhere.
[1]: http://www.gossamer-threads.com/lists/linux/kernel/2396533
> >> + if (IS_ERR(usb20_clk)) { >> + pr_err("could not get usb20 clk\n"); >> + return; >> + } > > Thanks, > Sekhar >
| |