lkml.org 
[lkml]   [2016]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 4/4] MIPS/kernel/proc: Combine four seq_printf() calls into one call in show_cpuinfo()
    On Mon, Oct 24, 2016 at 2:30 PM, SF Markus Elfring
    <elfring@users.sourceforge.net> wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Mon, 24 Oct 2016 13:54:58 +0200
    >
    > Some data were printed into a sequence by four separate function calls.
    > Print the same data by one function call instead.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > arch/mips/kernel/proc.c | 15 +++++++++------
    > 1 file changed, 9 insertions(+), 6 deletions(-)
    >
    > diff --git a/arch/mips/kernel/proc.c b/arch/mips/kernel/proc.c
    > index 07480a9..1047a03 100644
    > --- a/arch/mips/kernel/proc.c
    > +++ b/arch/mips/kernel/proc.c
    > @@ -142,12 +142,15 @@ static int show_cpuinfo(struct seq_file *m, void *v)
    > seq_printf(m, "micromips kernel\t: %s\n",
    > (read_c0_config3() & MIPS_CONF3_ISA_OE) ? "yes" : "no");
    > }
    > - seq_printf(m, "shadow register sets\t: %d\n",
    > - cpu_data[n].srsets);
    > - seq_printf(m, "kscratch registers\t: %d\n",
    > - hweight8(cpu_data[n].kscratch_mask));
    > - seq_printf(m, "package\t\t\t: %d\n", cpu_data[n].package);
    > - seq_printf(m, "core\t\t\t: %d\n", cpu_data[n].core);
    > + seq_printf(m,
    > + "shadow register sets\t: %d\n"
    > + "kscratch registers\t: %d\n"
    > + "package\t\t\t: %d\n"
    > + "core\t\t\t: %d\n",
    > + cpu_data[n].srsets,
    > + hweight8(cpu_data[n].kscratch_mask),
    > + cpu_data[n].package,
    > + cpu_data[n].core);

    I think the code is much easier to read with separate seq_printf()s for
    each line printed.

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2016-10-25 10:56    [W:4.813 / U:0.576 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site