Messages in this thread | | | From | Kees Cook <> | Date | Mon, 24 Oct 2016 16:17:33 -0700 | Subject | Re: [PATCH v6] powerpc: Do not make the entire heap executable |
| |
On Thu, Oct 20, 2016 at 3:45 PM, Jason Gunthorpe <jgunthorpe@obsidianresearch.com> wrote: > On Tue, Oct 04, 2016 at 09:54:12AM -0700, Kees Cook wrote: >> On Mon, Oct 3, 2016 at 5:18 PM, Michael Ellerman <mpe@ellerman.id.au> wrote: >> > Kees Cook <keescook@chromium.org> writes: >> > >> >> On Mon, Oct 3, 2016 at 9:13 AM, Denys Vlasenko <dvlasenk@redhat.com> wrote: >> >>> On 32-bit powerpc the ELF PLT sections of binaries (built with --bss-plt, >> >>> or with a toolchain which defaults to it) look like this: >> > ... >> >>> >> >>> Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> >> >>> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com> >> >>> Acked-by: Kees Cook <keescook@chromium.org> >> >>> Acked-by: Michael Ellerman <mpe@ellerman.id.au> >> >>> CC: Benjamin Herrenschmidt <benh@kernel.crashing.org> >> >>> CC: Paul Mackerras <paulus@samba.org> >> >>> CC: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> >> >>> CC: Kees Cook <keescook@chromium.org> >> >>> CC: Oleg Nesterov <oleg@redhat.com> >> >>> CC: Michael Ellerman <mpe@ellerman.id.au> >> >>> CC: Florian Weimer <fweimer@redhat.com> >> >>> CC: linux-mm@kvack.org >> >>> CC: linuxppc-dev@lists.ozlabs.org >> >>> CC: linux-kernel@vger.kernel.org >> >>> Changes since v5: >> >>> * made do_brk_flags() error out if any bits other than VM_EXEC are set. >> >>> (Kees Cook: "With this, I'd be happy to Ack.") >> >>> See https://patchwork.ozlabs.org/patch/661595/ >> >> >> >> Excellent, thanks for the v6! Should this go via the ppc tree or the -mm tree? >> > >> > -mm would be best, given the diffstat I think it's less likely to >> > conflict if it goes via -mm. >> >> Okay, excellent. Andrew, do you have this already in email? I think >> you weren't on the explicit CC from the v6... > > FWIW (and ping), > > Tested-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> > > On ARM32 (kirkwood) and PPC32 (405) > > For reference, here is the patchwork URL: > > https://patchwork.ozlabs.org/patch/677753/
Hi Andrew,
Can you pick this up?
Thanks!
-Kees
-- Kees Cook Nexus Security
| |