lkml.org 
[lkml]   [2016]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user
On Mon, Oct 24, 2016 at 04:09:37AM -0700, Michael Zoran wrote:
> I didn't think it looked totally correct, but I'm not sure it's any
> more broken then what is already in the tree.

It's not more broken. But better to leave the compile warning there to
mark that it is an obvious security problem.

>
> If you can kindly point me to some other source code or documentation
> to look at that is correct, I'm more then willing to fix the patch.
>

I was hoping the maintainers could chip in, because I didn't want to
look at the code. We really need to track which are use pointers and
which are kernel pointers. We can't mix them like this.

regards,
dan carpenter

\
 
 \ /
  Last update: 2016-10-24 13:37    [W:0.064 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site