Messages in this thread | | | Subject | Re: [PATCH] block: zoned: fix harmless maybe-uninitialized warning | From | Jens Axboe <> | Date | Mon, 24 Oct 2016 20:51:36 -0600 |
| |
On 10/24/2016 07:00 PM, Martin K. Petersen wrote: >>>>>> "Arnd" == Arnd Bergmann <arnd@arndb.de> writes: > > Arnd> The blkdev_report_zones produces a harmless warning when > Arnd> -Wmaybe-uninitialized is set, after gcc gets a little confused > Arnd> about the multiple 'goto' here: > > Arnd> block/blk-zoned.c: In function 'blkdev_report_zones': > Arnd> block/blk-zoned.c:188:13: error: 'nz' may be used uninitialized in > Arnd> this function [-Werror=maybe-uninitialized] > > Arnd> Moving the assignment to nr_zones makes this a little simpler > Arnd> while also avoiding the warning reliably. I'm removing the > Arnd> extraneous initialization of 'int ret' in the same patch, as that > Arnd> is semi-related and could cause an uninitialized use of that > Arnd> variable to not produce a warning. > > Jens: Are you picking up Arnd's two fixes for the zoned code?
Yep, adding them now. Thanks Arnd.
-- Jens Axboe
| |