| Date | Fri, 21 Oct 2016 10:57:20 -0400 | From | Theodore Ts'o <> | Subject | Re: [PATCH 02/26] fscrypto: Constify struct inode pointer |
| |
On Fri, Oct 21, 2016 at 02:48:17PM +0200, Richard Weinberger wrote: > Some filesystems, such as UBIFS, maintain a const pointer > for struct inode. > > /* fname.c */ > -extern int fscrypt_setup_filename(struct inode *, const struct qstr *, > - int lookup, struct fscrypt_name *); > +extern int fscrypt_setup_filename(struct inode *dir, const struct qstr *iname, > + int lookup, struct fscrypt_name *fname);
Was it deliberate that you didn't add a const pointer here?
I take it that ubifs is basically using const in certain places to essentially promise that those functions don't actually modify the inode structure?
- Ted
|