Messages in this thread | | | From | Punit Agrawal <> | Subject | Re: [PATCH] acpi/apei: Fix in-correct return value | Date | Fri, 21 Oct 2016 15:58:15 +0100 |
| |
"Baicar, Tyler" <tbaicar@codeaurora.org> writes:
> On 10/18/2016 10:07 AM, Punit Agrawal wrote: >> Although ghes_proc tests for error while reading the error status, it >> always return success (0). Fix this by propagating the return value. >> >> Fixes: d334a49113a4a33 ("ACPI, APEI, Generic Hardware Error Source memory error support") >> Signed-of-by: Punit Agrawal <punit.agrawa.@arm.com> >> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> >> Cc: Len Brown <lenb@kernel.org> > Tested-by: Tyler Baicar <tbaicar@codeaurora.org>
Thanks for taking the patch for a spin.
Hopefully Rafael can pick the patch as a fixes for the next rc.
> > Thanks, > Tyler >> --- >> drivers/acpi/apei/ghes.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c >> index f0a029e..0d099a2 100644 >> --- a/drivers/acpi/apei/ghes.c >> +++ b/drivers/acpi/apei/ghes.c >> @@ -662,7 +662,7 @@ static int ghes_proc(struct ghes *ghes) >> ghes_do_proc(ghes, ghes->estatus); >> out: >> ghes_clear_estatus(ghes); >> - return 0; >> + return rc; >> } >> static void ghes_add_timer(struct ghes *ghes)
| |