lkml.org 
[lkml]   [2016]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 net-next 8/8] net: qualcomm: add QCA7000 UART driver
    From
    Date
    Am 18.10.2016 um 20:30 schrieb David Miller:
    > From: Stefan Wahren <stefan.wahren@i2se.com>
    > Date: Tue, 18 Oct 2016 13:27:34 +0200
    >
    >> +void
    >> +qca_tty_receive(struct tty_struct *tty, const unsigned char *cp, char *fp,
    >> + int count)
    >> +{
    >> + struct qcauart *qca = tty->disc_data;
    >> + struct net_device_stats *n_stats = &qca->net_dev->stats;
    >> + int dropped = 0;
    > Please order local variable declarations from longest to shortest line.

    Even if the current second init depends on the first one?



    \
     
     \ /
      Last update: 2016-10-21 13:39    [W:2.681 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site