lkml.org 
[lkml]   [2016]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.8 46/57] ext4: fix memory leak when symlink decryption fails
    Date
    4.8-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Eric Biggers <ebiggers@google.com>

    commit dcce7a46c6f28f41447272fb44348ead8f584573 upstream.

    This bug was introduced in v4.8-rc1.

    Signed-off-by: Eric Biggers <ebiggers@google.com>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ext4/symlink.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/fs/ext4/symlink.c
    +++ b/fs/ext4/symlink.c
    @@ -65,13 +65,12 @@ static const char *ext4_encrypted_get_li
    res = fscrypt_fname_alloc_buffer(inode, cstr.len, &pstr);
    if (res)
    goto errout;
    + paddr = pstr.name;

    res = fscrypt_fname_disk_to_usr(inode, 0, 0, &cstr, &pstr);
    if (res < 0)
    goto errout;

    - paddr = pstr.name;
    -
    /* Null-terminate the name */
    if (res <= pstr.len)
    paddr[res] = '\0';

    \
     
     \ /
      Last update: 2016-10-21 11:29    [W:4.030 / U:0.404 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site