Messages in this thread | | | Subject | Re: [PATCH] acpi/apei: Fix in-correct return value | From | "Baicar, Tyler" <> | Date | Thu, 20 Oct 2016 13:51:31 -0600 |
| |
On 10/18/2016 10:07 AM, Punit Agrawal wrote: > Although ghes_proc tests for error while reading the error status, it > always return success (0). Fix this by propagating the return value. > > Fixes: d334a49113a4a33 ("ACPI, APEI, Generic Hardware Error Source memory error support") > Signed-of-by: Punit Agrawal <punit.agrawa.@arm.com> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Len Brown <lenb@kernel.org> Tested-by: Tyler Baicar <tbaicar@codeaurora.org>
Thanks, Tyler > --- > drivers/acpi/apei/ghes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > index f0a029e..0d099a2 100644 > --- a/drivers/acpi/apei/ghes.c > +++ b/drivers/acpi/apei/ghes.c > @@ -662,7 +662,7 @@ static int ghes_proc(struct ghes *ghes) > ghes_do_proc(ghes, ghes->estatus); > out: > ghes_clear_estatus(ghes); > - return 0; > + return rc; > } > > static void ghes_add_timer(struct ghes *ghes)
-- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
| |