lkml.org 
[lkml]   [2016]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 6/9] clk: sunxi-ng: Add A64 clocks
    On 10/11, Maxime Ripard wrote:
    > diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c
    > new file mode 100644
    > index 000000000000..c0e96bf6d104
    > --- /dev/null
    > +++ b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c
    > +
    > +static int sun50i_a64_ccu_probe(struct platform_device *pdev)
    > +{
    > + struct resource *res;
    > + void __iomem *reg;
    > + u32 val;
    > +
    > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    > + reg = devm_ioremap_resource(&pdev->dev, res);
    > + if (IS_ERR(reg)) {
    > + dev_err(&pdev->dev, "Could not map the clock registers\n");

    devm_ioremap_resource() should already spit out an error.

    > + return PTR_ERR(reg);
    > + }
    > +
    > + /* Force the PLL-Audio-1x divider to 4 */
    > + val = readl(reg + SUN50I_A64_PLL_AUDIO_REG);
    > + val &= ~GENMASK(19, 16);
    > + writel(val | (3 << 16), reg + SUN50I_A64_PLL_AUDIO_REG);
    > +
    > + writel(0x515, reg + SUN50I_A64_PLL_MIPI_REG);
    > +
    > + return sunxi_ccu_probe(pdev->dev.of_node, reg, &sun50i_a64_ccu_desc);
    > +}
    > +
    > +static const struct of_device_id sun50i_a64_ccu_ids[] = {
    > + { .compatible = "allwinner,sun50i-a64-ccu" },
    > + { },

    Nitpick: drop the comma

    > +};
    > +
    > +static struct platform_driver sun50i_a64_ccu_driver = {
    > + .probe = sun50i_a64_ccu_probe,
    > + .driver = {
    > + .name = "sun50i-a64-ccu",
    > + .of_match_table = sun50i_a64_ccu_ids,
    > + },
    > +};
    > +builtin_platform_driver(sun50i_a64_ccu_driver);

    --
    Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
    a Linux Foundation Collaborative Project

    \
     
     \ /
      Last update: 2016-10-20 20:46    [W:2.520 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site