Messages in this thread | | | Date | Thu, 20 Oct 2016 19:26:21 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH v4 2/9] clk: sunxi-ng: Remove the use of rational computations |
| |
On Thu, Oct 20, 2016 at 10:30:36PM +0800, Chen-Yu Tsai wrote: > On Tue, Oct 11, 2016 at 10:28 PM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > While the rational library works great, it doesn't really allow us to add > > more constraints, like the minimum. > > > > Remove that in order to be able to deal with the constraints we'll need. > > > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > --- > > drivers/clk/sunxi-ng/Kconfig | 3 +-- > > drivers/clk/sunxi-ng/ccu_nkm.c | 31 +++++++++----------- > > drivers/clk/sunxi-ng/ccu_nkmp.c | 45 +++++++++++++--------------- > > drivers/clk/sunxi-ng/ccu_nm.c | 54 +++++++++++++++++++++++++--------- > > 4 files changed, 78 insertions(+), 55 deletions(-) > > > > [...] > > > diff --git a/drivers/clk/sunxi-ng/ccu_nkmp.c b/drivers/clk/sunxi-ng/ccu_nkmp.c > > index 9769dee99511..4b457d8cce11 100644 > > --- a/drivers/clk/sunxi-ng/ccu_nkmp.c > > +++ b/drivers/clk/sunxi-ng/ccu_nkmp.c > > @@ -9,16 +9,15 @@ > > */ > > > > #include <linux/clk-provider.h> > > -#include <linux/rational.h> > > > > #include "ccu_gate.h" > > #include "ccu_nkmp.h" > > > > struct _ccu_nkmp { > > - unsigned long n, max_n; > > - unsigned long k, max_k; > > - unsigned long m, max_m; > > - unsigned long p, max_p; > > + unsigned long n, min_n, max_n; > > + unsigned long k, min_k, max_k; > > + unsigned long m, min_m, max_m; > > + unsigned long p, min_p, max_p; > > Wrong patch? Otherwise, > > Acked-by: Chen-Yu Tsai <wens@csie.org>
Indeed, fixed and applied.
Thanks! Maxime
-- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |