lkml.org 
[lkml]   [2016]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 1/13] md/multipath: Use kcalloc() in multipath_run()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sat, 1 Oct 2016 20:40:42 +0200

    * A multiplication for the size determination of a memory allocation
    indicated that an array data structure should be processed.
    Thus reuse the corresponding function "kcalloc".

    This issue was detected by using the Coccinelle software.

    * Replace the specification of a data structure by a pointer dereference
    to make the corresponding size determination a bit safer according to
    the Linux coding style convention.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/md/multipath.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/md/multipath.c b/drivers/md/multipath.c
    index 673efbd..bd53451 100644
    --- a/drivers/md/multipath.c
    +++ b/drivers/md/multipath.c
    @@ -408,7 +408,8 @@ static int multipath_run (struct mddev *mddev)
    goto out;
    }

    - conf->multipaths = kzalloc(sizeof(struct multipath_info)*mddev->raid_disks,
    + conf->multipaths = kcalloc(mddev->raid_disks,
    + sizeof(*conf->multipaths),
    GFP_KERNEL);
    if (!conf->multipaths) {
    printk(KERN_ERR
    --
    2.10.0
    \
     
     \ /
      Last update: 2016-10-02 13:58    [W:3.961 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site