Messages in this thread | | | Subject | Re: [media] winbond-cir: Move a variable assignment in wbcir_tx() | From | SF Markus Elfring <> | Date | Wed, 19 Oct 2016 16:05:59 +0200 |
| |
>> * How do you think about to avoid a variable assignment in case >> that this memory allocation failed anyhow? > > There is no memory allocation that can fail at this point.
Do you really know the failure probability for a call of the function "kmalloc" (within the function "wbcir_tx") under all possible run time situations?
>> * Do you care for data access locality? > > Not unless you can show measurable performance improvements?
Did any software developer (before me) dare anything in this direction?
Regards, Markus
| |