| Date | Tue, 18 Oct 2016 14:21:04 -0400 (EDT) | Subject | Re: [PATCH 20/28] net: bcm63xx: avoid referencing uninitialized variable | From | David Miller <> |
| |
From: Arnd Bergmann <arnd@arndb.de> Date: Tue, 18 Oct 2016 00:16:08 +0200
> gcc found a reference to an uninitialized variable in the error handling > of bcm_enet_open, introduced by a recent cleanup: > > drivers/net/ethernet/broadcom/bcm63xx_enet.c: In function 'bcm_enet_open' > drivers/net/ethernet/broadcom/bcm63xx_enet.c:1129:2: warning: 'phydev' may be used uninitialized in this function [-Wmaybe-uninitialized] > > This makes the use of that variable conditional, so we only reference it > here after it has been used before. Unlike my normal patches, I have not > build-tested this one, as I don't currently have mips test in my > randconfig setup. > > Fixes: 625eb8667d6f ("net: ethernet: broadcom: bcm63xx: use phydev from struct net_device") > Cc: Philippe Reynes <tremyfr@gmail.com> > Reported-by: kbuild test robot <fengguang.wu@intel.com> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
|