Messages in this thread | | | Date | Tue, 18 Oct 2016 20:47:32 +0300 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH v9 2/2] ARM: dts: add TOPEET itop elite based board |
| |
On Tue, Oct 18, 2016 at 08:37:48PM +0300, Krzysztof Kozlowski wrote: > On Wed, Oct 19, 2016 at 01:18:49AM +0800, Randy Li wrote: > > The TOPEET itop exynos 4412 have three versions base board. The > > Elite version is the cheap one without too much peripheral devices > > on it. > > > > Currently supported are serial console, wired networking(USB), > > USB OTG in peripheral mode, USB host, SD storage, GPIO buttons, > > PWM beeper, ADC and LEDs. The WM8960 analog audio codec is also > > enabled. > > > > The FIMC is not used for camera currently, I enabled it just for a > > colorspace converter. > > > > Signed-off-by: Randy Li <ayaka@soulik.info> > > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > > Thanks, applied, with missing Rob's ack, minor changes in commit msg and > fix in pin function (you used macro for pull up/down instead of > function).
I also changed your name in commit message from "ayaka" to "Randy Li". The author of a patch (equal to "From:" in email) should match the Signed-off-by. For the future, please fix your gitconfig and/or mail transfer program.
Sample gitconfig regarding this: [user] name = Mr Foo Bar email = foobar@gmail.com [sendemail] smtpencryption = tls smtpserver = smtp.gmail.com smtpuser = foobar@gmail.com smtpserverport = 587 confirm = auto
Best regards, Krzysztof
| |