lkml.org 
[lkml]   [2016]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 81/84] mfd: 88pm80x: Double shifting bug in suspend/resume
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit 9a6dc644512fd083400a96ac4a035ac154fe6b8d upstream.

    set_bit() and clear_bit() take the bit number so this code is really
    doing "1 << (1 << irq)" which is a double shift bug. It's done
    consistently so it won't cause a problem unless "irq" is more than 4.

    Fixes: 70c6cce04066 ('mfd: Support 88pm80x in 80x driver')
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    include/linux/mfd/88pm80x.h | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/include/linux/mfd/88pm80x.h b/include/linux/mfd/88pm80x.h
    index 97cb283cc8e1..0d37e8da3654 100644
    --- a/include/linux/mfd/88pm80x.h
    +++ b/include/linux/mfd/88pm80x.h
    @@ -349,7 +349,7 @@ static inline int pm80x_dev_suspend(struct device *dev)
    int irq = platform_get_irq(pdev, 0);

    if (device_may_wakeup(dev))
    - set_bit((1 << irq), &chip->wu_flag);
    + set_bit(irq, &chip->wu_flag);

    return 0;
    }
    @@ -361,7 +361,7 @@ static inline int pm80x_dev_resume(struct device *dev)
    int irq = platform_get_irq(pdev, 0);

    if (device_may_wakeup(dev))
    - clear_bit((1 << irq), &chip->wu_flag);
    + clear_bit(irq, &chip->wu_flag);

    return 0;
    }
    --
    2.10.1
    \
     
     \ /
      Last update: 2016-10-17 09:57    [W:3.620 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site