Messages in this thread | | | Date | Mon, 17 Oct 2016 09:39:28 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH 6/8] IB/hns: Replace counting semaphore event_sem with wait condition |
| |
On Mon, Oct 17, 2016 at 10:01:00PM +0530, Binoy Jayan wrote: > Counting semaphores are going away in the future, so replace the semaphore > hns_roce_cmdq::event_sem with an open-coded implementation.
Sorry, but no. Using a proper semaphore abstraction is always better than open coding it. While most semaphore users should move to better primitives, those that actually are counting semaphore should stick to the existing primitive.
| |