Messages in this thread | | | Subject | Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption | From | Johannes Berg <> | Date | Mon, 17 Oct 2016 09:47:58 +0200 |
| |
On Mon, 2016-10-17 at 08:37 +0100, Ard Biesheuvel wrote: > > Could we get a statement first whether it is supported to allocate > aead_req (and other crypto req structures) on the stack?
Well, we haven't heard from Herbert :)
> If not, then > we have our work cut out for us. But if it is, I'd rather we didn't > apply the kzalloc/kfree patch, since it is just a workaround for the > broken generic CCM driver, for which a fix is already available.
Yeah but I can't apply it. I just fixed up your kzalloc patch to also handle GCM and GMAC, and to have error checking. Will send it in a minute.
> Also, regarding your __percpu patch: those are located in the vmalloc > area as well, at least on arm64, and likely other architectures too.
Crap. Any other bright ideas?
johannes
| |