lkml.org 
[lkml]   [2016]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 1/3] Coccinelle: misc: Improve the matching of rules
    Date
    Currently because of the left associativity of the operators, pattern
    IRQF_ONESHOT | flags does not match with the pattern when we have more
    than one flag after the disjunction. This eventually results in giving
    false positives by the script. This patch eliminates these FPs by
    improving the rule.

    Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com>
    ---
    scripts/coccinelle/misc/irqf_oneshot.cocci | 30 ++++++++++++++++++++++++------
    1 file changed, 24 insertions(+), 6 deletions(-)

    diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci
    index b421150..b538d08 100644
    --- a/scripts/coccinelle/misc/irqf_oneshot.cocci
    +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci
    @@ -18,13 +18,12 @@ virtual report
    expression dev;
    expression irq;
    expression thread_fn;
    -expression flags;
    position p;
    @@
    (
    request_threaded_irq@p(irq, NULL, thread_fn,
    (
    -flags | IRQF_ONESHOT
    +IRQF_ONESHOT | ...
    |
    IRQF_ONESHOT
    )
    @@ -32,20 +31,39 @@ IRQF_ONESHOT
    |
    devm_request_threaded_irq@p(dev, irq, NULL, thread_fn,
    (
    -flags | IRQF_ONESHOT
    +IRQF_ONESHOT | ...
    |
    IRQF_ONESHOT
    )
    , ...)
    )

    -@depends on patch@
    +@r2@
    expression dev;
    expression irq;
    expression thread_fn;
    expression flags;
    +expression ret;
    position p != r1.p;
    @@
    +flags = IRQF_ONESHOT | ...;
    +(
    +ret = request_threaded_irq@p(irq, NULL, thread_fn, flags, ...);
    +|
    +ret = devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...);
    +|
    +return request_threaded_irq@p(irq, NULL, thread_fn, flags, ...);
    +|
    +return devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...);
    +)
    +
    +@depends on patch@
    +expression dev;
    +expression irq;
    +expression thread_fn;
    +expression flags;
    +position p != {r1.p,r2.p};
    +@@
    (
    request_threaded_irq@p(irq, NULL, thread_fn,
    (
    @@ -69,13 +87,13 @@ devm_request_threaded_irq@p(dev, irq, NULL, thread_fn,
    )

    @depends on context@
    -position p != r1.p;
    +position p != {r1.p,r2.p};
    @@
    *request_threaded_irq@p(...)

    @match depends on report || org@
    expression irq;
    -position p != r1.p;
    +position p != {r1.p,r2.p};
    @@
    request_threaded_irq@p(irq, NULL, ...)

    --
    2.1.4
    \
     
     \ /
      Last update: 2016-10-16 19:20    [W:5.630 / U:0.444 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site