lkml.org 
[lkml]   [2016]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] watchdog: bcm7038_wdt: fix module autoload
On Fri, Oct 14, 2016 at 12:23:50PM -0300, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/watchdog/bcm7038_wdt.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/watchdog/bcm7038_wdt.ko | grep alias
> alias: of:N*T*Cbrcm,bcm7038-wdtC*
> alias: of:N*T*Cbrcm,bcm7038-wdt
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>
> drivers/watchdog/bcm7038_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/bcm7038_wdt.c b/drivers/watchdog/bcm7038_wdt.c
> index e238df4d75a2..4814c00b32f6 100644
> --- a/drivers/watchdog/bcm7038_wdt.c
> +++ b/drivers/watchdog/bcm7038_wdt.c
> @@ -216,6 +216,7 @@ static const struct of_device_id bcm7038_wdt_match[] = {
> { .compatible = "brcm,bcm7038-wdt" },
> {},
> };
> +MODULE_DEVICE_TABLE(of, bcm7038_wdt_match);
>
> static struct platform_driver bcm7038_wdt_driver = {
> .probe = bcm7038_wdt_probe,
> --
> 2.7.4
>

\
 
 \ /
  Last update: 2016-10-14 18:56    [W:0.076 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site