Messages in this thread | | | Date | Thu, 13 Oct 2016 10:01:03 +0100 | From | Chris Wilson <> | Subject | Re: [Intel-gfx] [patch] drm/i915: fix a read size argument |
| |
On Thu, Oct 13, 2016 at 11:55:08AM +0300, Dan Carpenter wrote: > We want to read 3 bytes here, but because the parenthesis are in the > wrong place we instead read: > > sizeof(intel_dp->edp_dpcd) == sizeof(intel_dp->edp_dpcd) > > which is one byte. > > Fixes: fe5a66f91c88 ("drm/i915: Read PSR caps/intermediate freqs/etc. only once on eDP") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Oops, does smatch catch this? I don't recall seeing the complaint in recent runs?
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
-- Chris Wilson, Intel Open Source Technology Centre
| |