Messages in this thread | | | Date | Thu, 13 Oct 2016 15:48:47 -0400 | From | Rich Felker <> | Subject | Re: [PATCH v8 2/2] clocksource: add J-Core timer/clocksource driver |
| |
On Thu, Oct 13, 2016 at 03:25:42PM -0400, Rich Felker wrote: > On Wed, Oct 12, 2016 at 11:31:26PM +0200, Daniel Lezcano wrote: > > > > --> System Type > > > > > > > > That is what you are looking for, a SUPERH config option selecting all the > > > > common options and then a JCORE config option adding the different missing > > > > bits, namely the CLKSRC_JCORE_PIT. > > > > > > We do have something like "system type" in arch/sh, and it's what I'm > > > trying to deprecate since it's the switch to select between all the > > > hard-coded board files, _or_ device tree. > > > > > > Since part of the goal of my DT overhaul is to be able (but not > > > forced) to produce kernels that run on a wide range of hardware, > > > rather than having a "system type (select one)" option, what about > > > individual boolean options like: > > > > > > config JCORE_SOC > > > bool "Support for J-Core SoCs" > > > select CLKSRC_JCORE_PIT > > > select JCORE_AIC > > > ... > > > > I'm perfectly fine with this. > > Does this adequately ensure that dependencies for the clocksource and > irq driver are met? If not, what else do I need to do?
I've checked and it seems the dependencies are always met for arch/sh, at least with device tree enabled (on which JCORE_SOC will depend), so it shouldn't matter.
Rich
| |