lkml.org 
[lkml]   [2016]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set_mc()
From
From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Fri, 7 Oct 2016 22:53:43 -0400

> vmxnet3_set_mc() still assumes zero is invalid pa:
> it assumes dma_mapping_error(...,0) returns true if vmxnet3_copy_mc() fails;
> it calls dma_unmap_single() iff new_table_pa is not zero.
>
> The patch adds an explicit variable to track status of new_table_pa.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>

Please use "bool" and "true"/"false" for boolean variables.

Thanks.

\
 
 \ /
  Last update: 2016-10-13 15:46    [W:0.164 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site