Messages in this thread | | | Date | Thu, 13 Oct 2016 09:43:23 -0400 (EDT) | Subject | Re: [PATCH] vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set_mc() | From | David Miller <> |
| |
From: Alexey Khoroshilov <khoroshilov@ispras.ru> Date: Fri, 7 Oct 2016 22:53:43 -0400
> vmxnet3_set_mc() still assumes zero is invalid pa: > it assumes dma_mapping_error(...,0) returns true if vmxnet3_copy_mc() fails; > it calls dma_unmap_single() iff new_table_pa is not zero. > > The patch adds an explicit variable to track status of new_table_pa. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Please use "bool" and "true"/"false" for boolean variables.
Thanks.
| |