lkml.org 
[lkml]   [2016]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 03/10] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac
    On Mon, Oct 10, 2016 at 10:13:35AM -0500, Rob Herring wrote:
    > On Fri, Oct 07, 2016 at 10:25:50AM +0200, Corentin Labbe wrote:
    > > This patch adds documentation for Device-Tree bindings for the
    > > Allwinner sun8i-emac driver.
    > >
    > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
    > > ---
    > > .../bindings/net/allwinner,sun8i-emac.txt | 70 ++++++++++++++++++++++
    > > 1 file changed, 70 insertions(+)
    > > create mode 100644 Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt
    > >
    > > diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt b/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt
    > > new file mode 100644
    > > index 0000000..92e4ef3b
    > > --- /dev/null
    > > +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt
    > > @@ -0,0 +1,70 @@
    > > +* Allwinner sun8i EMAC ethernet controller
    > > +
    > > +Required properties:
    > > +- compatible: should be one of the following string:
    > > + "allwinner,sun8i-a83t-emac"
    > > + "allwinner,sun8i-h3-emac"
    > > + "allwinner,sun50i-a64-emac"
    > > +- reg: address and length of the register for the device.
    > > +- syscon: A phandle to the syscon of the SoC
    > > +- interrupts: interrupt for the device
    > > +- clocks: A phandle to the reference clock for this device
    > > +- clock-names: should be "ahb"
    > > +- resets: A phandle to the reset control for this device
    > > +- reset-names: should be "ahb"
    > > +- phy-mode: See ethernet.txt
    > > +- phy-handle: See ethernet.txt
    > > +- #address-cells: shall be 1
    > > +- #size-cells: shall be 0
    > > +
    > > +Optional properties:
    > > +- allwinner,tx-delay: TX clock delay chain value. Range value is 0-0x07. Default is 0)
    > > +- allwinner,rx-delay: RX clock delay chain value. Range value is 0-0x1F. Default is 0)
    > > +Both delay properties does not have units, there are arbitrary value.
    >
    > They have to have some sort of units. Some number of clocks perhaps. Or
    > just say what register field they correspond to.
    >

    I have re-read all 3 datasheets (A64/H3/A83T) and made string search for finding any information.
    But still found nothing, no unit, no more informations than I already wrote in this file.

    For the register field, just saying that it is used in the syscon register EMAC_CLK_REG is sufficient ?

    > > +The TX/RX clock delay chain settings are board specific and could be found
    > > +in vendor FEX files.
    > > +

    Regards

    Corentin Labbe

    \
     
     \ /
      Last update: 2016-10-13 15:40    [W:2.833 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site