Messages in this thread | | | Date | Thu, 13 Oct 2016 13:24:45 +0300 | From | Mika Westerberg <> | Subject | Re: [PATCH 1/2] Revert "HID: i2c-hid: Add support for ACPI GPIO interrupts" |
| |
On Thu, Oct 13, 2016 at 11:30:44AM +0200, Benjamin Tissoires wrote: > From: David Arcari <darcari@redhat.com> > > This reverts commit a485923efbb8 ("HID: i2c-hid: Add support for ACPI > GPIO interrupts") and commit a7d2bf25a483 ("HID: i2c-hid: Do not fail > probing if gpiolib is not enabled") at the same time. > > Since commit c884fbd45214 ("gpio / ACPI: Add support for retrieving > GpioInt resources from a device") i2c_core already set the IRQ by > looking into the ACPI tree and retrieving the gpioInt. So we just > have some boiler-plate here that is not needed anymore. > > The only downside effect here is that now we are not exiting early > enough if the irq is set to -EPROBE_DEFER or any other error, but > this is going to be fixed in the following patch. > > Signed-off-by: David Arcari <darcari@redhat.com> > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
I went through my collection of ACPI dumps from different machines and I did not find anything using plain GpioIo() resource. So I think this should be safe thing to do.
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
| |