Messages in this thread | | | From | Robert Jarzmik <> | Subject | Re: [PATCH 6/6] cpufreq: pxa: convert to clock API | Date | Wed, 12 Oct 2016 21:12:26 +0200 |
| |
Viresh Kumar <viresh.kumar@linaro.org> writes:
>> >> PXA architecture have both legacy platform_data based configurations and new >> >> devicetree based ones. >> > >> > I don't see any platform data specific code in this driver. What am I >> > missing ? >> >> In a legacy platform, ie. without devicetree, we have CONFIG_OF=n. >> How would cpufreq-dt be usable in this case ? >> >> You can see such a platform in arch/arm/configs/mainstone_defconfig and >> arch/arm/mach-pxa/mainstone.c as an example. > > Okay, so its not about platform_data as you said earlier. Rather it is > about the CONFIG_OF option. We're bickering about terminology.
Mine is that there are globally : - platform_data _based_ configurations => drivers probing devices rely on platform_data structures for initial configuration => that implies CONFIG_OF=n => pxa2xx-cpufreq is one of them, even if in this case no platform_data is used
- devicetree based configurations => drivers probing devices rely on device-tree blob for initial configuration => that implies CONFIG_OF=y
- ACPI based configurations => drivers probing devices rely on ACPI data
- maybe PCI would deserve a place, but I don't think there is much configuration in it
> In that case, what about making this driver depends_on !CONFIG_OF ? So > that the DT users don't use it anymore. Good idea, let me try it. I'll see if it actually works before make another iteration of this patch.
Cheers.
-- Robert
| |