Messages in this thread Patch in this message | | | From | Rob Herring <> | Subject | [PATCH 2/2] driver core: fix smatch warning on dev->bus check | Date | Tue, 11 Oct 2016 13:41:03 -0500 |
| |
Commit d42a09802174 (driver core: skip removal test for non-removable drivers) introduced a smatch warning:
drivers/base/dd.c:386 really_probe() warn: variable dereferenced before check 'dev->bus' (see line 373)
Fix the warning by removing the dev->bus NULL check. dev->bus will never be NULL, so the check was unnecessary.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/base/dd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 8937a7ad7165..d76cd97a98b6 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -384,7 +384,7 @@ static int really_probe(struct device *dev, struct device_driver *drv) if (test_remove) { test_remove = false; - if (dev->bus && dev->bus->remove) + if (dev->bus->remove) dev->bus->remove(dev); else if (drv->remove) drv->remove(dev); -- 2.10.0
| |