lkml.org 
[lkml]   [2016]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: parisc crash on boot with 4.8+git
* Meelis Roos <mroos@linux.ee>:
> > > Memory Ranges:
> > > 0) Start 0x0000000000000000 End 0x000000003fffffff Size 1024 MB
> > > 1) Start 0x0000004040000000 End 0x000000407fdfffff Size 1022 MB
> > > Total Memory: 2046 MB

Meelis and myself debugged the crash off-list.
It turns out, that I missed to zero-initialize the new memblocks.
Patch below fixes this.

Helge

------------
parisc: Zero-initialize newly alloced memblock

Commit 4fe9e1d957e4 ("parisc: Drop bootmem and switch to memblock")
switched to the memblock allocator, but missed to zero-initialize the
newly allocated memblocks. This lead to crashes on some machines like
the rp3410.

Fixes: 4fe9e1d957e4 ("parisc: Drop bootmem and switch to memblock")
Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/arch/parisc/mm/init.c b/arch/parisc/mm/init.c
index 356f384..62ac801 100644
--- a/arch/parisc/mm/init.c
+++ b/arch/parisc/mm/init.c
@@ -105,6 +105,8 @@ static void * __init get_memblock(unsigned long size)
else
panic("get_memblock() failed.\n");

+ memset(__va(phys), 0, size);
+
return __va(phys);
}

\
 
 \ /
  Last update: 2016-10-11 20:47    [W:0.334 / U:0.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site