Messages in this thread | | | Subject | Re: [PATCH/RFT 09/12] usb: host: ohci-da8xx: Add devicetree bindings documentation | From | David Lechner <> | Date | Mon, 10 Oct 2016 18:33:25 -0500 |
| |
On 10/07/2016 11:42 AM, ahaslam@baylibre.com wrote: > From: Axel Haslam <ahaslam@baylibre.com> > > This patch documents the device tree bindings required for > the ohci controller found in TI da8xx family of SoC's > > Signed-off-by: Axel Haslam <ahaslam@baylibre.com> > --- > .../devicetree/bindings/usb/ohci-da8xx.txt | 32 ++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/ohci-da8xx.txt > > diff --git a/Documentation/devicetree/bindings/usb/ohci-da8xx.txt b/Documentation/devicetree/bindings/usb/ohci-da8xx.txt > new file mode 100644 > index 0000000..e954ce5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/ohci-da8xx.txt > @@ -0,0 +1,32 @@ > +DA8XX USB OHCI controller > + > +Required properties: > + > + - compatible: Should be "ti,da830-ohci" > + - reg: Should contain one register range i.e. start and length > + - interrupts: Description of the interrupt line > + - phys: Phandle for the PHY device > + - phy-names: Should be "usb-phy" > +
If these are required, shouldn't they say "Must" instead of "Should"?
> +Optional properties: > + - vbus-gpio: If present, specifies a gpio that needs to be > + activated for the bus to be powered. > + - oci-gpio: If present, specifies a gpio that needs to be > + activated for the overcurrent detection. > + - power_on_delay: Power On to Power Good time - in ms. > + > +Example for omap138-lck: > + > +usb_phy: usb-phy { > + compatible = "ti,da830-usb-phy"; > + #phy-cells = <1>; > + status = "disabled"; > +}; > +usb11: usb11@0225000 { > + compatible = "ti,da830-ohci"; > + reg = <0x225000 0x1000>; > + interrupts = <59>; > + phys = <&usb_phy 1>; > + phy-names = "usb-phy"; > + status = "disabled"; > +}; >
| |