lkml.org 
[lkml]   [2016]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 12/12] scsi/ncr5380: Suppress unhelpful "interrupt without IRQ bit" message
    Date
    If a NCR5380 host instance ends up on a shared interrupt line then
    this printk will be a problem. It is already a problem on some Mac
    models: when testing mac_scsi on a PowerBook 180 I found that PDMA
    transfers (but not PIO transfers) cause the message to be logged.

    These spurious interrupts don't appear to come from the DRQ signal from
    the 5380. And they don't happen at all on the Mac LC III. A comment in
    the NetBSD source code mentions this mystery. Testing seems to show
    that we can safely ignore these interrupts.

    Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
    Reviewed-by: Hannes Reinecke <hare@suse.com>
    Tested-by: Ondrej Zary <linux@rainbow-software.org>
    Tested-by: Michael Schmitz <schmitzmic@gmail.com>
    ---
    drivers/scsi/NCR5380.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
    index 72ac31cd..0c3c7e6 100644
    --- a/drivers/scsi/NCR5380.c
    +++ b/drivers/scsi/NCR5380.c
    @@ -995,7 +995,7 @@ static irqreturn_t __maybe_unused NCR5380_intr(int irq, void *dev_id)
    }
    handled = 1;
    } else {
    - shost_printk(KERN_NOTICE, instance, "interrupt without IRQ bit\n");
    + dsprintk(NDEBUG_INTR, instance, "interrupt without IRQ bit\n");
    #ifdef SUN3_SCSI_VME
    dregs->csr |= CSR_DMA_ENABLE;
    #endif
    --
    2.7.3
    \
     
     \ /
      Last update: 2016-10-10 06:48    [W:4.309 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site