lkml.org 
[lkml]   [2016]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 02/15] md-cluster: Improve another size determination in resync_info_update()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sat, 1 Oct 2016 11:37:24 +0200

    Replace the specification of a data structure by a variable name
    as the parameter for the operator "sizeof" to make the corresponding size
    determination a bit safer.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/md/md-cluster.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c
    index 0000e3a..c28f596 100644
    --- a/drivers/md/md-cluster.c
    +++ b/drivers/md/md-cluster.c
    @@ -1057,7 +1057,7 @@ static int resync_info_update(struct mddev *mddev, sector_t lo, sector_t hi)

    /* do not send zero again, if we have sent before */
    if (hi == 0) {
    - memcpy(&ri, cinfo->bitmap_lockres->lksb.sb_lvbptr, sizeof(struct resync_info));
    + memcpy(&ri, cinfo->bitmap_lockres->lksb.sb_lvbptr, sizeof(ri));
    if (le64_to_cpu(ri.hi) == 0)
    return 0;
    }
    --
    2.10.0
    \
     
     \ /
      Last update: 2016-10-01 16:48    [W:5.672 / U:0.700 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site