lkml.org 
[lkml]   [2016]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 01/15] md-cluster: Use kcalloc() in lock_all_bitmaps()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sat, 1 Oct 2016 11:18:40 +0200

    * A multiplication for the size determination of a memory allocation
    indicated that an array data structure should be processed.
    Thus reuse the corresponding function "kcalloc".

    This issue was detected by using the Coccinelle software.

    * Replace the specification of a data type by a pointer dereference
    to make the corresponding size determination a bit safer according to
    the Linux coding style convention.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/md/md-cluster.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    diff --git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c
    index 2b13117..0000e3a 100644
    --- a/drivers/md/md-cluster.c
    +++ b/drivers/md/md-cluster.c
    @@ -1188,9 +1188,10 @@ static int lock_all_bitmaps(struct mddev *mddev)
    char str[64];
    struct md_cluster_info *cinfo = mddev->cluster_info;

    - cinfo->other_bitmap_lockres = kzalloc((mddev->bitmap_info.nodes - 1) *
    - sizeof(struct dlm_lock_resource *),
    - GFP_KERNEL);
    + cinfo->other_bitmap_lockres = kcalloc(mddev->bitmap_info.nodes - 1,
    + sizeof(*cinfo
    + ->other_bitmap_lockres),
    + GFP_KERNEL);
    if (!cinfo->other_bitmap_lockres) {
    pr_err("md: can't alloc mem for other bitmap locks\n");
    return 0;
    --
    2.10.0
    \
     
     \ /
      Last update: 2016-10-01 16:47    [W:4.138 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site