Messages in this thread | | | Date | Sat, 9 Jan 2016 00:04:26 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH 34/35] block: add QUEUE_FLAGs for flush and fua |
| |
On Tue, Jan 05, 2016 at 02:53:37PM -0600, mchristi@redhat.com wrote: > From: Mike Christie <mchristi@redhat.com> > > The last patch added a REQ_OP_FLUSH for request_fn drivers > and the next patch renames REQ_FLUSH to REQ_PREFLUSH which > will be used by file systems and make_request_fn drivers. > > This leaves REQ_FLUSH/REQ_FUA defined for drivers to tell > the block layer if flush/fua is supported. The names are > confusing and I bet will will accidentally be used by > people to request flushes. To avoid that, this patch adds > QUEUE_FLAGs for flush and fua which drivers will use to > indicate what they support. > > Signed-off-by: Mike Christie <mchristi@redhat.com>
Yes, this was rather confusing before. Looks great fix the fix for th kbuild complaint:
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |