Messages in this thread | | | Date | Fri, 8 Jan 2016 16:47:41 +0800 | From | Minfei Huang <> | Subject | Re: [PATCH v3 2/2] kexec: Provide arch_kexec_protect(unprotect)_crashkres() |
| |
On 01/08/16 at 10:33am, Xunlei Pang wrote: > + > +static int > +kexec_mark_range(unsigned long start, unsigned long end, bool protect) > +{ > + struct page *page; > + unsigned int nr_pages; > + > + /* For physical range: [start, end] */ > + if (!end || start > end) > + return 0;
This test !end is hard to be understood without the annotation. It is better to add the comment about it.
Otherwise it looks good for me.
Thanks Minfei
| |