lkml.org 
[lkml]   [2016]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/6] DT: mfd: add device-tree binding doc fro PMIC max77620/max20024
    On Fri, Jan 8, 2016 at 12:06 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
    > Thanks Rob for review.
    > I have taken care of all comment except following which I have query.
    >
    > On Friday 08 January 2016 04:42 AM, Rob Herring wrote:
    >>
    >> + - maxim,low-battery-reset-enable: Enable low battery reset.
    >> + - maxim,low-battery-reset-disable: Disable low battery reset.
    >> Why not boolean? Not present means keep default value? I'd prefer
    >> boolean or tristate of not present, 0 to disable, or 1 to enable.
    >>
    >>
    > Here, the properties are boolean. I will add this on the description.
    >
    > I like to enable or disable with the DT and properties are not there then
    > left to default.
    > So added two properties for enable and disable. If properties are there, do
    > the activity.
    >
    > Here tristate is also possible:
    > maxim,low-battery-reset: tristate, low battery reset control. 0 for disable,
    > 1 for enable and
    > absence of this will leave configuration on
    > default.
    >
    > Does it look fine?

    Yes.

    Rob

    \
     
     \ /
      Last update: 2016-01-08 16:01    [W:3.342 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site