Messages in this thread | | | Date | Fri, 8 Jan 2016 22:32:37 +0900 | Subject | Re: [rtc-linux] [PATCH 2/6] mfd: max77620: add core driver for MAX77620/MAX20024 | From | Krzysztof Kozlowski <> |
| |
2016-01-08 22:19 GMT+09:00 Laxman Dewangan <ldewangan@nvidia.com>: > > On Friday 08 January 2016 06:44 PM, Krzysztof Kozlowski wrote: >> >> >> To avoid compilation warning, I need to use inline here. >> Because this shouldn't be defined in header at the first place. Instead >> define it in main MFD driver with EXPORT_SYMBOL() and put in headers >> just declaration. >> > what about __maybe_unused instead on inline and keep in header. > > Anyhow, I do not have any personal choice here.
This just shouldn't be defined in header because that makes it spreading over many object files. There are just no benefits.
Best regards, Krzysztof
| |