Messages in this thread | | | Subject | Re: [PATCH v2 4/5] firmware: actually return NULL on failed request_firmware_nowait() | From | Shuah Khan <> | Date | Thu, 7 Jan 2016 13:56:57 -0700 |
| |
On 12/09/2015 03:50 PM, Brian Norris wrote: > The kerneldoc for request_firmware_nowait() says that it may call the > provided cont() callback with @fw == NULL, if the firmware request > fails. However, this is not the case when called with an empty string > (""). This case is short-circuited by the 'name[0] == '\0'' check > introduced in commit 471b095dfe0d ("firmware_class: make sure fw requests > contain a name"), so _request_firmware() never gets to set the fw to > NULL. >
Thanks for the patch. Applied to linux-kselftest next for 4.5-rc1.
thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978
| |