Messages in this thread Patch in this message | | | Date | Thu, 7 Jan 2016 12:38:39 -0800 | From | Brian Norris <> | Subject | [PATCH] misc: cxl: fix build for GCC 4.6.x |
| |
GCC 4.6.3 does not support -Wno-unused-const-variable. Instead, use the kbuild infrastructure that checks if this options exists.
Also drop -Werror, since it's harmful, if forced on the user. New GCC's, or higher warning verbosities (e.g., W=1) can easily kill the build where they shouldn't.
Suggested-by: Michal Marek <mmarek@suse.com> Signed-off-by: Brian Norris <computersforpeace@gmail.com> ---
On Thu, Jan 07, 2016 at 12:18:26PM -0800, Brian Norris wrote: > On Thu, Jan 07, 2016 at 11:57:31AM -0800, Joe Perches wrote: > > On Thu, 2016-01-07 at 20:44 +0100, Michal Marek wrote: > > > We have cc-disable-warning for this. > > > > Thanks Michal. > > Cool, thanks! I'll send a patch to use that instead.
drivers/misc/cxl/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/cxl/Makefile b/drivers/misc/cxl/Makefile index 6982f603fadc..0163d4d1fd1e 100644 --- a/drivers/misc/cxl/Makefile +++ b/drivers/misc/cxl/Makefile @@ -1,4 +1,4 @@ -ccflags-y := -Werror -Wno-unused-const-variable +ccflags-y := $(call cc-disable-warning, unused-const-variable) cxl-y += main.o file.o irq.o fault.o native.o cxl-y += context.o sysfs.o debugfs.o pci.o trace.o -- 2.6.0.rc2.230.g3dd15c0
| |