lkml.org 
[lkml]   [2016]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers
On Thu, Jan 07, 2016 at 09:23:27AM -0800, Babu Moger wrote:
> I have never seen auto handoff working on TI and RENESAS cards.
> Eventually, we force handoff. This code forces the handoff
> unconditionally. It saves 5 seconds boot time for each card.
>
> Signed-off-by: Babu Moger <babu.moger@oracle.com>
> ---
> drivers/usb/host/pci-quirks.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> index f940056..b7ee895 100644
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -1003,6 +1003,13 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
> ext_cap_offset = xhci_find_next_cap_offset(base, ext_cap_offset);
> } while (1);
>
> + /* Auto handoff never worked for these devices. Force it and continue */
> + if (pdev->vendor == PCI_VENDOR_ID_TI ||
> + pdev->vendor == PCI_VENDOR_ID_RENESAS) {
> + val = (val | XHCI_HC_OS_OWNED) & ~XHCI_HC_BIOS_OWNED;

odd spaces here, why this format?

And are you sure that all TI and Renesas host controllers have this
issue? That's a very wide and broad test you are making here...

thanks,

greg k-h


\
 
 \ /
  Last update: 2016-01-07 19:01    [W:0.121 / U:1.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site