Messages in this thread | | | From | Juergen Borleis <> | Subject | Re: [PATCH 3/3] RTC/PCF85063: fix time/date setting | Date | Thu, 7 Jan 2016 11:13:00 +0100 |
| |
Hi Alexandre,
sorry, missed your comment. Please keep me on CC since I'm not subscribed to the list.
> > When setting a new time/date the RTC's clock must be stopped first, in > > order to write the time/date registers in an atomic manner. > > So, this change stops the clock first and then writes the time/date > > registers and the clock control register (to re-enable the clock) in one > > turn. > > I'd have the same comment for that patch. Using > i2c_smbus_write_byte_data and i2c_smbus_write_block_data would make the > code clearer and also more robust because it takes care of > retransmissions for example.
Okay. Will have a look.
Regards, Juergen
-- Pengutronix e.K. | Juergen Borleis | Industrial Linux Solutions | http://www.pengutronix.de/ |
| |