Messages in this thread | | | Date | Wed, 6 Jan 2016 10:09:34 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCHv8 0/8] perf stat: Add scripting support |
| |
On Tue, Jan 05, 2016 at 07:39:20PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jan 05, 2016 at 10:09:04PM +0100, Jiri Olsa escreveu: > > hi, > > sending another version of stat scripting. > > > > v8 changes: > > - check for stat callbacks properly [Namhyung] > > - used '#!/usr/bin/env python' for stat-cpi.py [Namhyung] > > - used tuple_set_u64 for storing u64 into python tuple [Namhyung] > > While testing this I noticed I failed to notice that after adding all > these new user meta events we have: > > [acme@zoo linux]$ perf stat -e cycles record usleep 1 > > Performance counter stats for 'usleep 1': > > 1,049,367 cycles > > 0.002616357 seconds time elapsed > > [acme@zoo linux]$ oldperf report --stdio > 0xf0 [0x28]: failed to process type: 73 > Error: > failed to process sample > # To display the perf.data header info, please use > # --header/--header-only options. > # > [acme@zoo linux]$ > > While it should just have ignored the user meta events if doesn't > support and state that the perf.data file had no samples :-\ > > So I think I'll make perf_session__process_user_event() return 0 > for events it doesn't support, just adding a pr_debug(), ok?
ok, but please put there something more visible.. so it's obvious it was hit
jirka
| |