Messages in this thread | | | Date | Thu, 7 Jan 2016 09:07:26 +0900 | From | Namhyung Kim <> | Subject | Re: [PATCH v3 3/5] perf tools: Fix dynamic sort keys to sort properly |
| |
On Wed, Jan 06, 2016 at 08:50:45PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Jan 06, 2016 at 08:31:49PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Thu, Jan 07, 2016 at 08:26:45AM +0900, Namhyung Kim escreveu: > > > On Wed, Jan 06, 2016 at 08:06:43PM -0300, Arnaldo Carvalho de Melo wrote: > > > > Em Wed, Jan 06, 2016 at 09:54:59AM +0900, Namhyung Kim escreveu: > > > > > Currently, the dynamic sort keys compares trace data using memcmp(). > > > > > But for output sorting, it should check data size and compare by word. > > > > > Also it sorted strings in reverse order, fix it. > > > > > > > > Can this be broken down in two patches? This is complex code, lets try > > > > to make it as bisectable as possible. > > > > > > OK, I'll break out the string part then. But I think it doesn't help > > > much to reduce the complexity. > > > > Well, number of patches is not a problem, everytime I see a "Also lets > > do this other thing" I cringe, it is automatic, sorry :-\ > > > > For reviewing its soooo much better to see things nicely separated, and > > sometimes I like one part but not the other, so I pick one and continue > > discussion on the other, etc. > > Ah, please rebase from my latest perf/core, I'm still holding on it > since some 'perf test' entries are failing and I want to check first if > its due to bugs introduced in this branch...
Will do!
Thanks, Namhyung
| |