Messages in this thread | | | Date | Wed, 6 Jan 2016 15:05:31 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH v4 2/3] ARM: dts: sun8i: Add Allwinner A83T dtsi |
| |
Hi Mark,
On Wed, Jan 06, 2016 at 01:25:05PM +0000, Mark Rutland wrote: > > + clocks { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges; > > + > > + osc24M: osc24M_clk { > > + #clock-cells = <0>; > > + compatible = "fixed-clock"; > > + clock-frequency = <24000000>; > > + clock-output-names = "osc24M"; > > + }; > > + > > + osc32k: osc32k_clk { > > + #clock-cells = <0>; > > + compatible = "fixed-clock"; > > + clock-frequency = <32768>; > > + clock-output-names = "osc32k"; > > + }; > > + }; > > Just put the clocks under the root node. 'clocks' is not a special > node.
No, it's not a special node, but it's a very convenient one. It avoids "crippling" the main SoC definition with all the clocks definition, and keep the noise relatively low.
And a bunch of other maintainers seem to agree: $ git grep "clocks {" -- arch/arm/boot/dts/ arch/arm64/boot/dts/ | wc -l 271
Maxime
-- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |