Messages in this thread | | | Date | Tue, 5 Jan 2016 23:11:10 -0800 | Subject | Re: [PATCH v7 3/3] x86, mce: Add __mcsafe_copy() | From | Dan Williams <> |
| |
On Tue, Jan 5, 2016 at 11:06 PM, Luck, Tony <tony.luck@intel.com> wrote: > You were heading towards: > > ld: undefined __mcsafe_copy
True, we'd also need a dummy mcsafe_copy() definition to compile it out in the disabled case.
> since that is also inside the #ifdef. > > Weren't you going to "select" this? >
I do select it, but by randconfig I still need to handle the CONFIG_X86_MCE=n case.
> I'm seriously wondering whether the ifdef still makes sense. Now I don't have an extra exception table and routines to sort/search/fixup, it doesn't seem as useful as it was a few iterations ago.
Either way is ok with me. That said, the extra definitions to allow it compile out when not enabled don't seem too onerous.
| |