lkml.org 
[lkml]   [2016]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.16.y-ckt 073/126] ALSA: hda - Fix headphone noise after Dell XPS 13 resume back from S3
    Date
    3.16.7-ckt22 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Hui Wang <hui.wang@canonical.com>

    commit 8c69729b4439bbda88c3073df7243f755cc418ed upstream.

    We have a machine Dell XPS 13 with the codec alc256, after resume back
    from S3, the headphone has noise when play sound.

    Through comparing with the coeff vaule before and after S3, we found
    restoring a coeff register will help remove noise.

    BugLink: https://bugs.launchpad.net/bugs/1519168
    Cc: Kailang Yang <kailang@realtek.com>
    Signed-off-by: Hui Wang <hui.wang@canonical.com>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    [ luis: backported to 3.16: adjusted context ]
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    sound/pci/hda/patch_realtek.c | 13 +++++++++++++
    1 file changed, 13 insertions(+)

    diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
    index e78193d905d9..379ece8c3afc 100644
    --- a/sound/pci/hda/patch_realtek.c
    +++ b/sound/pci/hda/patch_realtek.c
    @@ -4318,6 +4318,7 @@ enum {
    ALC292_FIXUP_TPT440_DOCK,
    ALC292_FIXUP_TPT440_DOCK2,
    ALC275_FIXUP_DELL_XPS,
    + ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE,
    };

    static const struct hda_fixup alc269_fixups[] = {
    @@ -4781,6 +4782,17 @@ static const struct hda_fixup alc269_fixups[] = {
    {}
    }
    },
    + [ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE] = {
    + .type = HDA_FIXUP_VERBS,
    + .v.verbs = (const struct hda_verb[]) {
    + /* Disable pass-through path for FRONT 14h */
    + {0x20, AC_VERB_SET_COEF_INDEX, 0x36},
    + {0x20, AC_VERB_SET_PROC_COEF, 0x1737},
    + {}
    + },
    + .chained = true,
    + .chain_id = ALC255_FIXUP_DELL1_MIC_NO_PRESENCE
    + },
    };

    static const struct snd_pci_quirk alc269_fixup_tbl[] = {
    @@ -4845,6 +4857,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
    SND_PCI_QUIRK(0x1028, 0x15cd, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
    SND_PCI_QUIRK(0x1028, 0x06d9, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),
    SND_PCI_QUIRK(0x1028, 0x06da, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),
    + SND_PCI_QUIRK(0x1028, 0x0704, "Dell XPS 13", ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE),
    SND_PCI_QUIRK(0x1028, 0x164a, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),
    SND_PCI_QUIRK(0x1028, 0x164b, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),
    SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2),

    \
     
     \ /
      Last update: 2016-01-06 12:21    [W:8.717 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site