lkml.org 
[lkml]   [2016]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.2.y-ckt 032/211] mtd: mtdpart: fix add_mtd_partitions error path
    Date
    4.2.8-ckt1 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Boris BREZILLON <boris.brezillon@free-electrons.com>

    commit e5bae86797141e4a95e42d825f737cb36d7b8c37 upstream.

    If we fail to allocate a partition structure in the middle of the partition
    creation process, the already allocated partitions are never removed, which
    means they are still present in the partition list and their resources are
    never freed.

    Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
    Signed-off-by: Brian Norris <computersforpeace@gmail.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/mtd/mtdpart.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
    index cafdb88..919a936 100644
    --- a/drivers/mtd/mtdpart.c
    +++ b/drivers/mtd/mtdpart.c
    @@ -664,8 +664,10 @@ int add_mtd_partitions(struct mtd_info *master,

    for (i = 0; i < nbparts; i++) {
    slave = allocate_partition(master, parts + i, i, cur_offset);
    - if (IS_ERR(slave))
    + if (IS_ERR(slave)) {
    + del_mtd_partitions(master);
    return PTR_ERR(slave);
    + }

    mutex_lock(&mtd_partitions_mutex);
    list_add(&slave->list, &mtd_partitions);
    --
    1.9.1


    \
     
     \ /
      Last update: 2016-01-05 22:21    [W:2.951 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site