lkml.org 
[lkml]   [2016]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 47/91] module: Call module notifier on failure after complete_formation()
    Date
    From: Steven Rostedt <rostedt@goodmis.org>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit 37815bf866ab6722a47550f8d25ad3f1a16a680c upstream.

    The module notifier call chain for MODULE_STATE_COMING was moved up before
    the parsing of args, into the complete_formation() call. But if the module failed
    to load after that, the notifier call chain for MODULE_STATE_GOING was
    never called and that prevented the users of those call chains from
    cleaning up anything that was allocated.

    Link: http://lkml.kernel.org/r/554C52B9.9060700@gmail.com

    Reported-by: Pontus Fuchs <pontus.fuchs@gmail.com>
    Fixes: 4982223e51e8 "module: set nx before marking module MODULE_STATE_COMING"
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    kernel/module.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/kernel/module.c b/kernel/module.c
    index 3e3f90d82ecc..7d1c2ea27898 100644
    --- a/kernel/module.c
    +++ b/kernel/module.c
    @@ -3337,6 +3337,9 @@ static int load_module(struct load_info *info, const char __user *uargs,
    module_bug_cleanup(mod);
    mutex_unlock(&module_mutex);

    + blocking_notifier_call_chain(&module_notify_list,
    + MODULE_STATE_GOING, mod);
    +
    /* we can't deallocate the module until we clear memory protection */
    unset_module_init_ro_nx(mod);
    unset_module_core_ro_nx(mod);
    --
    2.6.4


    \
     
     \ /
      Last update: 2016-01-05 19:21    [W:4.294 / U:0.472 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site